Repository navigation
ci: update to Changesets CLI v3 for changesets/action v2, and revert the unpublished 2.3.4 - #293
Conversation
v2 only works with Changesets CLI v3, and tapable is on @changesets/cli v2, so
the Release workflow fails before publishing ("Changesets CLI v2 is not
supported; use Changesets action v1 instead") and 2.3.4 never reached npm.
🦋 Changeset detectedLatest commit: fa6d12a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. WalkthroughThe release workflow passes the GitHub token and renamed inputs to the Changesets action. The Changesets CLI and GitHub-info dependency versions and schema reference are updated. The changelog generator retries commit and pull-request lookups, normalizes lookup results into nullable links, and uses those links when formatting release lines. Merge Risk:
|
changesets/action v2 only works with Changesets CLI v3, so the Release workflow stopped before publishing. Instead of pinning the action back: - @changesets/cli ^3 and @changesets/get-github-info ^1; the changelog generator moves to its getCommitInfo/getPullRequestInfo API, as webpack's did - the workflow keeps changesets/action v2.1.2 with its renamed inputs (github-token, version-script, publish-script, commit-message, pr-title)
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
#292 versioned 2.3.4, but the Release workflow failed before publishing it. Restore its changesets, the 2.3.3 version and the changelog, so the fixed workflow opens the release pull request again once this merges.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 15 15
Lines 805 805
Branches 140 140
=======================================
Hits 799 799
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance1 warning
Comparing |
Summary
2.3.4 was versioned by #292 but never published: npm and the GitHub releases still show 2.3.3 as latest.
#290 bumped
changesets/actionfrom v1.9.0 to v2.1.2, a major version. v2 only works with Changesets CLI v3, and tapable was on@changesets/cliv2, so the Release workflow stops before publishing:v2 also renamed the inputs, so this workflow's inputs were ignored there.
This keeps action v2 and updates the rest to match, the same setup webpack runs:
@changesets/cli^3 and@changesets/get-github-info^1. The$schemain.changeset/config.jsonnow points at@changesets/config3.1.4..changeset/changelog-generator.mjsmoves toget-github-infov1's API:getInfo/getInfoFromPullRequestbecamegetCommitInfo/getPullRequestInfo, which returnmarkdownLinks. It's now the same file as webpack's, which also retries GitHub lookups so a transient API drop doesn't fail a release.release.ymlkeepschangesets/actionv2.1.2 with its renamed inputs:version→version-scriptpublish→publish-scriptcommit→commit-messagetitle→pr-titleGITHUB_TOKENenv becomes thegithub-tokeninputpackage.jsongoes back to 2.3.3, the 2.3.4 CHANGELOG entry is removed, and the two changesets chore(release): new release #292 consumed (fix: type the call and loop interceptor arguments as the hook's own #288 and fix: declare TypedHookMap as an interface #291) are restored. Once this merges, the Release workflow opens the release pull request again with CLI v3. Merging that one publishes 2.3.4.What kind of change does this PR introduce?
ci
Did you add tests for your changes?
No, this is CI, dev dependencies and release metadata only.
npm run lintandnpm testpass.changeset statuslists tapable as a pending patch from the restored changesets.The release pull request the workflow opens after this merges is the full check.
Does this PR introduce a breaking change?
No. Only CI, dev dependencies and unpublished release metadata change.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
n/a
Use of AI
Written with Claude Code (diagnosis from the Release job logs, the migration following webpack's setup, the release revert and this description), directed and reviewed by me.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HArJAXZagrHVVNLZZk9soh
Summary by CodeRabbit
TypedHookMapinterface typing and interceptor argument types.